Skip to content
This repository has been archived by the owner on Aug 10, 2024. It is now read-only.

Get Started updates #228

Closed
wants to merge 3 commits into from
Closed

Get Started updates #228

wants to merge 3 commits into from

Conversation

omesser
Copy link
Contributor

@omesser omesser commented Nov 17, 2022

https://mlem-ai-simplify-get-st-gwz7i9.herokuapp.com/doc/get-started

I've identified some issues which in my mind make the get started not as appealing and simple to understand as it could be

  • The get started workflows today are "actions" - applying/serving/building/deploying. New users might not understand what those mean, in what order should they "put the pieces to gether" and this might lose apeal.
    Some questions I can imagine here for new ysers:

    • "where should I start? I obviously care about all of those, I think"
    • "deploying vs serving? sounds the same"
    • "what does applying a model mean"?
    • "does it make sense to learn about deploying without building? building before applying?"
  • "productionization" term is not a clear / common enough in my mind. It's a big catch-all term. it's the umbrella for all current get-started guides.

My Suggestion here - let's have full scenarios drive the GS structure - so less scenarios (2), more stages in each

Suggested Structure:

- Model Prediction
	- loading model and predicting in code
	- batch scoring
- Deploying and serving models
	- running a local server
	- building/packaging models
	- deploying models to cloud

@omesser omesser marked this pull request as draft November 17, 2022 18:16
@shcheklein shcheklein temporarily deployed to mlem-ai-simplify-get-st-gwz7i9 November 17, 2022 18:16 Inactive
@github-actions
Copy link

github-actions bot commented Nov 17, 2022

d434045

Link Check Report

2/24 links failed.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 18, 2022

Great Qs cc @aguschin . Relates to discussion in #58 (comment) (in fact this PR may close that issue).

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 18, 2022

Suggested Structure

  • basic model management ... saving and loading ... model inferencing and batch scoring
  • Deploying and serving models ... running a local server ... building/packaging ... deploying to cloud

For the record, what I originally recommended was similar:

combining the multiple current pages into 2 larger/more meaningful sections
i. Capturing models (saving + packaging?)
ii. Productionizing (applying, serving, deploying)

Though I also think that the saving part is pretty good for the index of the section, as is now. (Does that answer "where should I start?" or do we mean"where to go after saving?")

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the saving part is pretty good for the index of the section, as is now.

Comparing with the new index page, my conviction that the existing one is preferable increases. Specific reasons:

content/docs/get-started/index.md Outdated Show resolved Hide resolved
content/docs/get-started/index.md Outdated Show resolved Hide resolved
content/docs/get-started/index.md Outdated Show resolved Hide resolved
content/docs/get-started/management.md Outdated Show resolved Hide resolved
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 18, 2022

I love the intention in this PR however other than the changes I reviewed above, we're mainly regrouping existing content. The grouping is probably good but should be combined with summarizing things because in this proposal one of the pages is pretty short and the second one kind of long (they don't seem to be at the same conceptual level). We also add notes and paragraphs making it even longer which worries me.

Get Started's are tricky 😓

@aguschin

This comment was marked as resolved.

Comment on lines 111 to 120
### Why do it the MLEM way

Saving models to files or loading them back into python objects may seem like a
deceptively simple task at first. For example, `pickle` and `torch` libraries
can serialize/deserialize model objects to/from files, but we will see that MLEM
adds some "special sauce" in the form of metadata files that will help us a lot
down the line in the heavier operations like packaging and serving of the models
in various ways. MLEM allows us to automate a lot of the pain points we would
hit later on in our ML workflow by codifying metadata about your models (and
other objects) and intelligently using it later on.
Copy link
Contributor

@aguschin aguschin Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also add notes and paragraphs making it even longer which worries me

@jorgeorpinel, does your comment refers to the sections like these? I understand your intention, but I think those make things much clear. Besides, we "sell" MLEM. We can hide them in <details> as an option, but I believe these can be very helpful. WDYT?

Copy link
Contributor

@jorgeorpinel jorgeorpinel Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also add notes and paragraphs making it even longer

does your comment refers to the sections like these?

Yes. The intention is good but we need the GS to be as brief and direct as possible. If we need to clarify something with an entire new section then it probably wasn't written properly in the first place (or there's an underlying product design issue).

p.s. sorry for late reply. Will check #238 post-merge.

@aguschin aguschin mentioned this pull request Nov 22, 2022
6 tasks
@omesser omesser temporarily deployed to mlem-ai-simplify-get-st-gwz7i9 November 23, 2022 19:23 Inactive
@omesser omesser temporarily deployed to mlem-ai-simplify-get-st-gwz7i9 November 23, 2022 21:11 Inactive
@aguschin aguschin closed this Dec 5, 2022
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: get-started Content of /doc/get-started type: enhancement Something is not clear, small updates, improvement suggestions labels Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: get-started Content of /doc/get-started type: enhancement Something is not clear, small updates, improvement suggestions
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants