Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vscode integration tests - altered quickpick behaviour #5561

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

mattseddon
Copy link
Member

No description provided.

@mattseddon mattseddon self-assigned this Jun 12, 2024
@mattseddon mattseddon added the bug Something isn't working label Jun 12, 2024
await commands.executeCommand('workbench.action.quickOpenSelectNext')

for (let itemInd = 1; itemInd <= itemsLength + 1; itemInd++) {
await commands.executeCommand('workbench.action.quickOpenNavigateNext')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] The quick pick no longer selects the first item by default so we have to navigate past the input bar on each loop

Copy link

codeclimate bot commented Jun 12, 2024

Code Climate has analyzed commit 4bfddee and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.3%.

View more on Code Climate.

@mattseddon mattseddon enabled auto-merge (squash) June 12, 2024 05:46
@mattseddon mattseddon disabled auto-merge June 12, 2024 05:46
@mattseddon mattseddon merged commit 4a47e80 into main Jun 12, 2024
8 checks passed
@mattseddon mattseddon deleted the fix-tests branch June 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant