Rename language association to recommend

extension/src/extension.ts

@@ -42,7 +42,7 @@ import {
   showWalkthroughOnFirstUse
 } from './vscode/walkthrough'
 import { WorkspaceRepositories } from './repository/workspace'
-import { tryAssociateYamlOnce } from './vscode/languageAssociation'
+import { recommendAssociateYamlOnce } from './vscode/recommend'
 
 export { Disposable, Disposer }
 
@@ -264,7 +264,7 @@ export class Extension implements IExtension {
     )
 
     showWalkthroughOnFirstUse(context.globalState)
-    this.dispose.track(tryAssociateYamlOnce())
+    this.dispose.track(recommendAssociateYamlOnce())
   }
 
   public async canRunCli(cwd: string) {

extension/src/test/suite/vscode/languageAssociation.test.ts → extension/src/test/suite/vscode/recommend.test.ts

@@ -10,7 +10,7 @@ suite('Language Association Test Suite', () => {
     restore()
   })
 
-  describe('tryAssociateYamlOnce', () => {
+  describe('recommendAssociateYamlOnce', () => {
     it('should only try and associate .dvc and dvc.lock files once per session', async () => {
       const getUri = (fileName: string) => Uri.file(join(dvcDemoPath, fileName))
 

extension/src/vscode/languageAssociation.test.ts → extension/src/vscode/recommend.test.ts

@@ -1,7 +1,7 @@
 import { mocked } from 'ts-jest/utils'
 import { window } from 'vscode'
 import { getConfigValue, setUserConfigValue } from './config'
-import { askUserToAssociateYaml } from './languageAssociation'
+import { recommendAssociateYaml } from './recommend'
 
 const mockedShowInformationMessage = jest.fn()
 const mockedWindow = mocked(window)
@@ -17,10 +17,10 @@ beforeEach(() => {
   jest.resetAllMocks()
 })
 
-describe('askUserToAssociateYaml', () => {
+describe('recommendAssociateYaml', () => {
   it('should set a user config option if the user responds with do not show again', async () => {
     mockedShowInformationMessage.mockResolvedValueOnce("Don't Show Again")
-    await askUserToAssociateYaml()
+    await recommendAssociateYaml()
 
     expect(mockedSetUserConfigValue).toBeCalledTimes(1)
     expect(mockedSetUserConfigValue).toBeCalledWith(
@@ -34,7 +34,7 @@ describe('askUserToAssociateYaml', () => {
     mockedGetConfigValue.mockReturnValueOnce({
       '*.wat': 'perl'
     })
-    await askUserToAssociateYaml()
+    await recommendAssociateYaml()
 
     expect(mockedSetUserConfigValue).toBeCalledTimes(1)
     expect(mockedSetUserConfigValue).toBeCalledWith('files.associations', {
@@ -46,14 +46,14 @@ describe('askUserToAssociateYaml', () => {
 
   it('should not set any options if the user responds with no', async () => {
     mockedShowInformationMessage.mockResolvedValueOnce('No')
-    await askUserToAssociateYaml()
+    await recommendAssociateYaml()
 
     expect(mockedSetUserConfigValue).not.toBeCalled()
   })
 
   it('should not set any options if the user cancels the dialog', async () => {
     mockedShowInformationMessage.mockResolvedValueOnce(undefined)
-    await askUserToAssociateYaml()
+    await recommendAssociateYaml()
 
     expect(mockedSetUserConfigValue).not.toBeCalled()
   })

extension/src/vscode/languageAssociation.ts → extension/src/vscode/recommend.ts

@@ -20,7 +20,7 @@ const addFileAssociations = () => {
   return setUserConfigValue('files.associations', fileAssociations)
 }
 
-export const askUserToAssociateYaml = async () => {
+export const recommendAssociateYaml = async () => {
   const response = await getYesOrNoOrNever(
     'Would you like to have "dvc.lock" and ".dvc" files recognized as YAML?'
   )
@@ -47,14 +47,14 @@ const alreadyAssociated = (): boolean => {
   )
 }
 
-export const tryAssociateYamlOnce = (): Disposable => {
+export const recommendAssociateYamlOnce = (): Disposable => {
   const singleUseListener = window.onDidChangeActiveTextEditor(editor => {
     if (alreadyAssociated() || getConfigValue(doNotAssociateYaml)) {
       return singleUseListener.dispose()
     }
 
     if (isFileType(editor?.document.fileName)) {
-      askUserToAssociateYaml()
+      recommendAssociateYaml()
       return singleUseListener.dispose()
     }
   })