Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application tests #324

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Application tests #324

wants to merge 1 commit into from

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Feb 28, 2023

The first small steps in automated testing of the application.

@rimi-itk rimi-itk force-pushed the feature/application-tests branch 4 times, most recently from 104d771 to 998abbf Compare February 28, 2023 21:16
@rimi-itk rimi-itk marked this pull request as ready for review March 1, 2023 07:23
@rimi-itk rimi-itk requested a review from jekuaitk March 1, 2023 07:24
@@ -86,6 +86,7 @@
"hautelook/alice-bundle": "^2.8",
"phpspec/prophecy-phpunit": "^2.0",
"phpstan/phpstan": "^1.3",
"phpunit/phpunit": "^9.5",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this installed through the dev requirementsymfony/phpunit-bridge (https://symfony.com/doc/5.4/components/phpunit_bridge.html), so is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, but https://symfony.com/doc/current/testing.html#the-phpunit-testing-framework recommends (i.e. tells us) to install symfony/test-pack which requires phpunit/phpunit (cf. https://github.com/symfony/test-pack/blob/main/composer.json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants