Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional digits to amount format #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JannickWeisshaupt
Copy link

Various UnitCode, e.g. MLT (Millilitre) imply sub-cent amounts and sub-cent amounts are generally allowed by the en16931 and Xrechnung standards.

Currently these sub-cent are omitted, which leads to seemingly false invoices, as the product of the charge amount times the quantity no longer equals the line total amount.

This PR adds 10 optional sub-cent digits to the amount-format entry for both german and english internalization files.

@bdewein
Copy link
Collaborator

bdewein commented Feb 14, 2023

@JannickWeisshaupt Thanks for reporting!
Restriction to two digits should be kept for amount-format in general, however, and more digits only allowed where appropriate.
Please track here: https://projekte.kosit.org/xrechnung/xrechnung-visualization/-/issues/139

@bdewein bdewein self-assigned this Feb 14, 2023
@JannickWeisshaupt
Copy link
Author

JannickWeisshaupt commented Feb 27, 2023

@bdewein thanks for taking this up. One question: I saw that you are going to use the at-least-two-format for specific fields instead of increasing the digits generally as I proposed. This sounds like a good idea.
However should the at-least-two-format not be
###,##0.00###############
instead of
###,##0.################# ?

@jochenkirstaetter
Copy link

Reviewing progress on GitLab - https://projekte.kosit.org/xrechnung/xrechnung-visualization/-/merge_requests/91 - this seems to be resolved and the PR should be closed, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants