Serve web UI without installation #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for another great PR, looks promising. I will try to review and merge it this week. |
UlrichEckhardt
force-pushed
the
feature/serve-web-ui-in-place
branch
from
e837f18
to
4f985af
Compare
UlrichEckhardt
force-pushed
the
feature/serve-web-ui-in-place
branch
from
4f985af
to
46c4cdf
Compare
Document that you can set the installation path to `false` in order to serve the web UI in-place, i.e. without copying it to some publicly served folder.
This treated only the root (typically '/clockwork') as part of the web UI. Now, it treats that and everything inside that dir as parts of the web UI.
In particular, you can now send a 'Content-type' header, so that this can be used to serve any type of file in the response.
This used to only serve the root HTML doc as container for the iframe with the actual app. Now, it treats anything under the root path (typically '/clockwork') as a web asset and serves it accordingly.
UlrichEckhardt
force-pushed
the
feature/serve-web-ui-in-place
branch
from
46c4cdf
to
e69060f
Compare
|
I ended up reworking this slightly and making it a default, which is a small breaking change for people using the web UI without specifying the paths explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya!
This should be the final PR to easily support Slim (or any PSR-compatible framework) out of the box. This allows setting the installation path for the web UI files to
falsein order to turn off installation altogether. Instead, it then serves the files of the web UI from the '/clockwork' root dir as well.This serves two use-cases:
php -S localhost:8080 -t public public/index.phpto serve a web interface.Cheers!
Uli