Update supported Crystal versions in "installation.md" #583
Conversation
|
I was already planning on bumping the version with #577 :P |
|
Oh, my bad, I didn't see your PR D: |
docs/installation.md
Outdated
| @@ -110,7 +110,9 @@ docker-compose up | |||
|
|
|||
| Follow the instructions for your distribution here: https://crystal-lang.org/install/ | |||
|
|
|||
| Note: Invidious currently supports the following Crystal versions: `1.9.2` / `1.8.2` / `1.7.X` / `1.6.X` | |||
| **Note:** Invidious currently supports the following Crystal versions: `1.9.2` / `1.10` / `1.11` / `1.12`. \ | |||
There was a problem hiding this comment.
Considering iv-org/invidious#4256 should 1.9.X be supported?
There was a problem hiding this comment.
Ah, that's something I completely forgot about. Yeah, this was fixed in 1.10 (crystal-lang/crystal#13705). Do we add a warning for 1.9? Or just remove that version entirely?
There was a problem hiding this comment.
I guess that depends on whether we consider "supporting" just meaning that Invidious can run on a particular version, or that it will run without any problems.
There was a problem hiding this comment.
Hmm, true. I think we should go for the latter: "supported" means that there is no wildcards attached.
There was a problem hiding this comment.
Sounds good to me. Can you remove 1.9?
|
@syeopite Sorry, I forgot to make that commit. Here are the requested changes! |
There was a problem hiding this comment.
Github does support admonitions now, and so does mkdocs. So maybe we should do something like this?
Warning
Note: Invidious currently supports the following Crystal versions: 1.10.x / 1.11.x / 1.12.x.
Versions 1.9.x and older are incompatible because we use features only present in the newer versions.
Versions 1.13.x should be compatible, however we did not test it.
|
I dont think that the invidious ci needs to be ran for 1.9.2 if it"s not supported: |
Thanks to two different users that made me realise that it was out of sync with our CI test matrix (version 1.8 and before fail due to the missing
String.match!()function in the stdlib)