Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Using shortlink redirects to channel instead of video #2347

Closed
austinhuang0131 opened this issue Aug 24, 2021 · 6 comments
Closed

[Bug] Using shortlink redirects to channel instead of video #2347

austinhuang0131 opened this issue Aug 24, 2021 · 6 comments
Labels
wontfix This will not be worked on

Comments

@austinhuang0131
Copy link

Describe the bug
Generally speaking /<video_id> redirects /watch?v=<video_id>.

However, somehow, /<video_id> was fetched as a channel URL instead in this case.

This affects Privacy Redirect's ability to redirect youtu.be links

Steps to Reproduce

  1. https://redirect.invidious.io/watch?v=dQw4w9WgXcQ redirects to the rickroll video, right?
  2. https://redirect.invidious.io/dQw4w9WgXcQ redirects to a channel called "SubToMe" whose custom channel URL is dQw4w9WgXcQ
@austinhuang0131 austinhuang0131 added the bug Something isn't working label Aug 24, 2021
@SamantazFox SamantazFox added wontfix This will not be worked on and removed bug Something isn't working labels Aug 25, 2021
@SamantazFox
Copy link
Member

Invidious (and by extension the redirection service we provide) is meant to handle youtube URLs, i.e under the www.youtube.com domain. Our goal is that for any www.youtube.com/url you can go to <invidious instance>/url and it will work. youtu.be is another domain that is exclusively used as an URL shortener for video URLs (i.e www.youtube.com/watch?v=<id>).

@austinhuang0131
Copy link
Author

austinhuang0131 commented Aug 25, 2021

So channel names are prioritized over video IDs? (Since https://redirect.invidious.io/pd8P12BXebo does go to the video with the ID) Alright.

@TheFrenchGhosty
Copy link
Member

I agree with @SamantazFox here, Privacy Redirect should rewrite it to include watch?v=

So channel names are prioritized over video IDs? (Since https://redirect.invidious.io/pd8P12BXebo does go to the video with the ID) Alright

We definitely have to look into that. Thanks for reporting it.

@austinhuang0131
Copy link
Author

austinhuang0131 commented Aug 27, 2021

Actually, wait:

eg. https://redirect.invidious.io/watch?v=LAXiHmwqsGg

The description contains youtu.be/<id> links, but clicking the first one goes to invidious.instance/<id>

@syeopite
Copy link
Member

Hmm this is strange. Technically Invidious's behavior is right. YouTube returns the first of those links as a urlEndpoint while the rest are given as a watchEndpoint.

As a result on YouTube the links traverse to:

And this is technically the behavior seen on Invidious. Just not the one you'd typically expect. Anyhow, #2365 should fix it.

@syeopite
Copy link
Member

#2347 (comment)

Closing as this has been fixed by #2365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants