Raise error if video not playable, also handle missing related videos #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcgarvey
requested review from
SamantazFox
and removed request for
a team
SamantazFox
approved these changes
Feb 11, 2022
Comment on lines
+954
to
+955
| secondary_results = main_results | ||
| .dig?("secondaryResults", "secondaryResults", "results") |
There was a problem hiding this comment.
Just not sure why you moved this block ^^ (yeah, that's nitpicking)
|
in testing on https://yewtu.be |
3 tasks
|
@unixfox seems good? |
|
Seems like yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2877
Related to #602
By returning params if
reasonis added to it and raising an exception if it's present, then we show an understandable error to users.7IpVsQVyok8is a video that is age restricted.Before
After
I noticed that while working with
7IpVsQVyok8it would occasionally return as playable and then fail because it didn't return any related videos. I updated the code to not fail on that. It shows the video, but without related videosExample
Normal video just for reference