Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new channel layout (part 2) #3419

Merged
merged 17 commits into from
Jan 10, 2023

Conversation

SamantazFox
Copy link
Member

@SamantazFox SamantazFox commented Nov 20, 2022

Fixes (again) partially #3371

@user234683
Copy link

Have you guys determined if arbitrary paging is possible with the new ctoken format? I did some experimentation and managed to get it to retrieve different pages by playing with the values, however I haven't yet checked if there's a server side check that prevents it from skipping pages

@SamantazFox SamantazFox force-pushed the new-channel-layout-2 branch 4 times, most recently from a77d5ec to f286505 Compare December 4, 2022 13:33
@SamantazFox SamantazFox force-pushed the new-channel-layout-2 branch 10 times, most recently from 303e845 to d2d6ef6 Compare December 5, 2022 18:57
@SamantazFox
Copy link
Member Author

Hmm, there are some weird things still going on...

Missing JSON element "reelPlayerHeaderSupportedRenderers" (BrokenTubeException)
  from invidious.git/src/invidious/yt_backend/extractors.cr:426:16 in 'parse'
  from invidious.git/src/invidious/yt_backend/extractors.cr:404:16 in 'process'
  from invidious.git/src/invidious/yt_backend/extractors.cr:386:17 in 'parse'
  from invidious.git/src/invidious/yt_backend/extractors.cr:380:16 in 'process'
  from invidious.git/src/invidious/yt_backend/extractors.cr:741:17 in 'parse_item'
  from invidious.git/src/invidious/yt_backend/extractors.cr:787:14 in 'extract_items'
  from invidious.git/src/invidious/channels/videos.cr:139:12 in 'get_shorts'
  from invidious.git/src/invidious/routes/api/v1/channels.cr:177:35 in 'shorts'
  from invidious.git/src/invidious/routing.cr:210:5 in '->'
  from invidious.git/lib/kemal/src/kemal/route.cr:12:26 in '->'
  from invidious.git/src/invidious/helpers/handlers.cr:30:37 in 'process_request'
  from invidious.git/lib/kemal/src/kemal/route_handler.cr:17:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/lib/kemal/src/kemal/websocket_handler.cr:13:14 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/lib/kemal/src/kemal/filter_handler.cr:21:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/src/invidious/helpers/handlers.cr:212:5 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/src/invidious/helpers/handlers.cr:94:12 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/src/invidious/helpers/handlers.cr:158:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/src/invidious/helpers/handlers.cr:70:5 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/src/ext/kemal_static_file_handler.cr:162:16 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/lib/kemal/src/kemal/exception_handler.cr:8:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/src/invidious/helpers/logger.cr:17:35 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from invidious.git/lib/kemal/src/kemal/init_handler.cr:12:7 in 'call'
  from /usr/share/crystal/src/http/server/request_processor.cr:51:11 in 'process'
  from /usr/share/crystal/src/http/server.cr:515:5 in 'handle_client'
  from /usr/share/crystal/src/http/server.cr:468:13 in '->'
  from /usr/share/crystal/src/fiber.cr:146:11 in 'run'
  from /usr/share/crystal/src/fiber.cr:98:34 in '->'
  from ???

@SamantazFox
Copy link
Member Author

Have you guys determined if arbitrary paging is possible with the new ctoken format? I did some experimentation and managed to get it to retrieve different pages by playing with the values, however I haven't yet checked if there's a server side check that prevents it from skipping pages

I've tried, and so far none of my attempts were successful. If you have a solution, I'll happily take it, but otherwise, I won't spend much more time fiddling around.

@SamantazFox SamantazFox marked this pull request as ready for review January 7, 2023 22:54
@SamantazFox SamantazFox requested a review from a team as a code owner January 7, 2023 22:54
@SamantazFox SamantazFox requested review from unixfox and removed request for a team January 7, 2023 22:54
@unixfox unixfox added the in-testing This feature has been deployed and is being tested label Jan 8, 2023
@unixfox
Copy link
Member

unixfox commented Jan 8, 2023

In testing on https://yewtu.be

Copy link
Member

@unixfox unixfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you. we didn't receive any bug report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-testing This feature has been deployed and is being tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants