Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Add support for new routes #4099

Merged
merged 3 commits into from
Oct 7, 2023

Conversation

SamantazFox
Copy link
Member

Closes #3607
Closes #4091

@SamantazFox SamantazFox requested a review from a team as a code owner September 13, 2023 21:54
@SamantazFox SamantazFox requested review from unixfox and removed request for a team September 13, 2023 21:54
@SamantazFox SamantazFox added the need-code-review A crystal developper need to check if the code is correct. label Sep 13, 2023
unixfox added a commit to yewtudotbe/invidious-custom that referenced this pull request Sep 13, 2023
@unixfox unixfox added the in-testing This feature has been deployed and is being tested label Sep 13, 2023
@SamantazFox SamantazFox removed the need-code-review A crystal developper need to check if the code is correct. label Sep 14, 2023
@SamantazFox
Copy link
Member Author

I might want to do a redirect for all unknown channel routes...

@unixfox
Copy link
Member

unixfox commented Sep 15, 2023

I might want to do a redirect for all unknown channel routes...

That's what I have been thinking we should do.

src/invidious/routing.cr Show resolved Hide resolved
src/invidious/routes/channels.cr Show resolved Hide resolved
@SamantazFox
Copy link
Member Author

@unixfox good to merge?

@unixfox
Copy link
Member

unixfox commented Sep 18, 2023

I guess so we haven't received any bad feedback about that.

@syeopite syeopite added ready and removed in-testing This feature has been deployed and is being tested labels Sep 18, 2023
@SamantazFox SamantazFox merged commit eddb54a into iv-org:master Oct 7, 2023
8 checks passed
@SamantazFox SamantazFox deleted the support-new-routes branch October 7, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants