Performance: Improve speed of automatic instance redirection #4193
Conversation
syeopite
force-pushed
the
refactor-instance-redirect
branch
from
5325e52
to
ac38c25
Compare
| @@ -40,7 +40,16 @@ module Invidious::Routes::Misc | |||
|
|
|||
| def self.cross_instance_redirect(env) | |||
| referer = get_referer(env) | |||
| instance_url = fetch_random_instance | |||
|
|
|||
| instance_list = Invidious::Jobs::InstanceListRefreshJob::INSTANCES["INSTANCES"] | |||
There was a problem hiding this comment.
I guess this should be used to add some sites for reddit comments eventually as well
invidious/src/invidious/comments/reddit.cr
Lines 8 to 9 in 9e8baa3
There was a problem hiding this comment.
Sounds good to me, this can be used for the eventual Lemmy source as well.
Though does Reddit's search functionality even support filtering for that many sites at once?
This comment has been minimized.
This comment has been minimized.
The HTTP::Client created via `make_client` is affected by the force_resolve configuration option. However, api.invidious.io does not support ipv6 and as such any request with ipv6 to api.invidious.io will instead raise. Directly calling the HTTP::Client will ignore the force_resolve option allowing requests to go through ipv4 when needed.
syeopite
force-pushed
the
refactor-instance-redirect
branch
from
a84100f
to
9980c0e
Compare
|
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
SamantazFox
added
the
in-testing
SamantazFox
added
ready
and removed
in-testing
|
Thanks for your contribution :) |
The automatic instance redirection implemented in #1940 fetches a new list of instances each time someone queries the
/redirectendpoint. This is extremely inefficient...This PR optimizes all that into a background job that only fetches a single list every 30 minutes. This should performance quite a bit.