Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Add rel="noreferrer noopener" to external links #4667

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

ulmemxpoc
Copy link
Contributor

@ulmemxpoc ulmemxpoc commented Apr 30, 2024

Related to #4297. CC: @SamantazFox.

Adds rel="noreferrer noopener" to constant YouTube links on Invidious frontend.
Also change to YT_URL.

Does not add rel="noreferrer noopener" to:

  • links in channel description
  • links in video descriptions
  • links in video comments

@ulmemxpoc ulmemxpoc requested a review from a team as a code owner April 30, 2024 03:45
@ulmemxpoc ulmemxpoc requested review from unixfox and removed request for a team April 30, 2024 03:45
src/invidious/views/watch.ecr Outdated Show resolved Hide resolved
src/invidious/frontend/comments_youtube.cr Outdated Show resolved Hide resolved
@ulmemxpoc
Copy link
Contributor Author

@SamantazFox applied suggested fixes. Please re-review.

@SamantazFox SamantazFox added the need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something label May 20, 2024
@SamantazFox SamantazFox added ready and removed need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Aug 11, 2024
@SamantazFox SamantazFox changed the title Add rel="noreferrer noopener" to external links HTML: Add rel="noreferrer noopener" to external links Aug 11, 2024
@SamantazFox SamantazFox merged commit 80ffc44 into iv-org:master Aug 11, 2024
@SamantazFox
Copy link
Member

Thanks for contributing to invidious :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants