-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add search button to search bar #4706
Conversation
Why? There is no description. |
Related: #4098 |
Because I find that sometimes I enter something into the box and later want to submit it without my keyboard around. I think it's generally a good idea for accessibility to make invidious usable without a keyboard. |
Ha ok you just added a button on the search bar. The title is very confusing. To be fair I quite like the way it is without any search button. I think I good compromise would be to just have the search icon. Not the full text "Search". Like on youtube.com |
I added an icon instead and used the aria-label for it with the translation like @ChunkyProgrammer suggested. Icon is using the currentColor so it works on dark and light theme. It's MIT licensed from heroicons. |
Please use the built-in icons instead: https://github.com/iv-org/invidious/blob/master/assets/fonts/ionicons.svg |
Yeah, that makes sense, it should be good now. |
Thanks for contributing to invidious :D |
Closes #529