-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channels: Fix for live videos #5027
Conversation
As this one fixes the problem properly, without removing functionality, I would suggest that this pull request should be considered the proper fix and that the other one be considered as the alternative or even closed now that there is a proper fix (so the opposite of what the titles currently say). |
fair enough |
I'll second absidue here: please close the other one as this one is more complete |
Applied to my instance. |
Thanks for testing it out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
thanks for finding out!
Protobuf values also changed for regular videos.
Tested on my local instance and it works now.
Thanks! It is being addressed in #5059 |
Superseded by #5059 |
Oh, wait, nevermind, your commits are in my own PR, no need to merge them separately! |
Thanks for your contribution btw! |
Closes #5021
This is an alternative to #5026 to keep the sort options working
After digging into the proto, live stream sorting has different values than channel videos