Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing vol_diff key to BinaryPairwiseMeasures.measures_dict #1

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

valosekj
Copy link
Member

This is a minor PR adding the missing vol_diff key to BinaryPairwiseMeasures.measures_dict.

Otherwise, the following KeyError is raised:

Traceback (most recent call last):
  File "/Users/user/code/MetricsReloaded/MetricsReloaded/metrics/pairwise_measures.py", line 1161, in to_dict_meas
    if len(self.measures_dict[key]) == 2:
KeyError: 'vol_diff'

Note: I also originally opened the same PR on Project-MONAI/MetricsReloaded: Project-MONAI#44. But it has not been merged yet.

Otherwise, the following KeyError is raised:

Traceback (most recent call last):
  File "/Users/user/code/MetricsReloaded/MetricsReloaded/metrics/pairwise_measures.py", line 1161, in to_dict_meas
    if len(self.measures_dict[key]) == 2:
KeyError: 'vol_diff'
Copy link
Member

@naga-karthik naga-karthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I remember looking at this but realized that it was under the actual MetricsReloaded repo! Disappointed that it's not active :/

Thanks for this change anyway though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants