Release 1.5.1 is freezing Brackets

[Pikoulol]

Hi,

Since I've updated Brackets-Icons from 1.5.0 to 1.5.1. My brackets UI is not responding.
When I open Brackets, the main window and the files tree is empty.
The top menu is visible but not responding.

To get it working again I've to move Brackets-Icons to the disabled extensions folder then restart Brackets.

Plugins installed :

• Brackets Outline List
• Documents Toolbar
• Extensions Rating
• Todo
• Tomorrow Night

[Pikoulol]

I made a test with Brackets and only your plugin installed.
Problem stays the same. So, it's not a conflict between plugins.

[cgfrost]

I think I know what might be causing this, I'll see if I can fix it. I can recreate the problem you are describing at least.

[ivogabe]

It looks to be only failing on Windows, on a Mac it runs without trouble.

@cgfrost What cause do you suspect? Can you create a fix?

[cgfrost]

I think it's the main loop in findInDictionary, I think there are some strange cases where it will never exit and keep looping. I'm working on it now. Should have a fix in the next hour or so.

[Hirse]

The problem occurs when the extension is deciding on the icon for a file whose name is not in the list of known file names and consists only of the file extension.

[Hirse]

This is fine:

But when I create a new file with a name like this it freezes as soon as I press enter.

[ivogabe]

@cgfrost The bug is probably on line 70, when dotIndex is 0 (as in the example of @Hirse), it'll pass -1 as the second argument to lastIndexOf, which probably means the second argument is ignored. dotIndexNext is then again 0, and that introduces an infinite loop. It should be assigned -1 instead.

[cgfrost]

Yeah, that is close to how I have recreated it. (I'm on a Mac by the way so I don't think this is Windows specific)

[cgfrost]

This pull request will fix things. (I'll stop tweeking the pull request as well)

[ivogabe]

Fixed in 1.5.2. The issue was indeed also available on Mac. (I didn't open any directories containing these unknown dot files on Mac, but I did open these on Windows)

[ivogabe]

If you have issues updating to 1.5.2, because Brackets doesn't respond any more due to the infinite loop, you should first remove Brackets Icons (ivogabe.icons) from the extensions directory:

• Mac: ~/Library/Application Support/Brackets/extensions/user
• Win: C:\Users\<user>\AppData\Roaming\Brackets\extensions\user
• Linux: ~/.config/brackets/extensions/user

[Pikoulol]

I've updated the plugin to version 1.5.2 and everything works fine now.

Thank you guys !