feat: better ux for wireguard config errors #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katibov
commented
Jul 25, 2022
katibov
commented
- aria-live="polite" attribute is set on error elements
- download buttons are not disabled by default
- error messages are shown and focues when download buttons are pressed
- error messages are removed as soon as valid input is provided
- aria-live="polite" attribute is set on error elements - download buttons are not disabled by default - error messages are shown and focues when download buttons are pressed - error messages are removed as soon as valid input is provided
|
This is a draft commit for this issue: #411. |
|
I wasn’t able to figure out how to set up dev environment with docker and/or laravel. Unfortunately I don’t have much experience with those tools. This means that I didn’t have chance to check how this code actually works on a built website. But I figured that the changes I’ve made are pretty trivial. Thus I’m committing this in order to provide a base stucture which should require very little changes if any to be merged into production. |
|
@islambegk Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.