fix: ivy.trapz and jnp.trapezoid frontend

ivy-llc · May 17, 2024 · e3c906a · e3c906a
1 parent 6d25d95
commit e3c906a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/ivy/functional/backends/jax/elementwise.py b/ivy/functional/backends/jax/elementwise.py
@@ -516,7 +516,7 @@ def trapz(
     axis: int = -1,
     out: Optional[JaxArray] = None,
 ) -> JaxArray:
-    return jnp.trapz(y, x=x, dx=dx, axis=axis)
+    return jnp.trapezoid(y, x=x, dx=dx, axis=axis)
 
 
 @with_unsupported_dtypes(

diff --git a/ivy/functional/backends/tensorflow/elementwise.py b/ivy/functional/backends/tensorflow/elementwise.py
@@ -4,8 +4,9 @@
 
 # local
 import ivy
-from ivy.func_wrapper import with_unsupported_dtypes, with_supported_dtypes
 from ivy import promote_types_of_inputs
+from ivy.func_wrapper import with_unsupported_dtypes, with_supported_dtypes
+from ivy.utils.exceptions import IvyNotImplementedException
 from . import backend_version
 
 
@@ -771,8 +772,8 @@ def trapz(
     axis: int = -1,
     out: Optional[Union[tf.Tensor, tf.Variable]] = None,
 ) -> Union[tf.Tensor, tf.Variable]:
-    pass
     # TODO: Implement purely in tensorflow
+    raise IvyNotImplementedException()
 
 
 @with_unsupported_dtypes({"2.15.0 and below": ("complex",)}, backend_version)

diff --git a/ivy/functional/frontends/jax/numpy/mathematical_functions.py b/ivy/functional/frontends/jax/numpy/mathematical_functions.py
@@ -903,10 +903,14 @@ def trace(a, offset=0, axis1=0, axis2=1, out=None):
 
 
 @to_ivy_arrays_and_back
-def trapz(y, x=None, dx=1.0, axis=-1, out=None):
+def trapezoid(y, x=None, dx=1.0, axis=-1, out=None):
     return ivy.trapz(y, x=x, dx=dx, axis=axis, out=out)
 
 
+def trapz(y, x=None, dx=1.0, axis=-1, out=None):
+    return trapezoid(y, x=x, dx=dx, axis=axis, out=out)
+
+
 @to_ivy_arrays_and_back
 def trunc(x):
     return ivy.trunc(x)

diff --git a/ivy_tests/test_ivy/test_frontends/test_jax/test_numpy/test_mathematical_functions.py b/ivy_tests/test_ivy/test_frontends/test_jax/test_numpy/test_mathematical_functions.py
@@ -3314,11 +3314,11 @@ def test_jax_trace(
 
 
 @handle_frontend_test(
-    fn_tree="jax.numpy.trapz",
+    fn_tree="jax.numpy.trapezoid",
     dtype_x_axis_rand_either=_either_x_dx(),
     test_with_out=st.just(False),
 )
-def test_jax_trapz(
+def test_jax_trapezoid(
     *,
     dtype_x_axis_rand_either,
     on_device,

diff --git a/ivy_tests/test_ivy/test_functional/test_core/test_elementwise.py b/ivy_tests/test_ivy/test_functional/test_core/test_elementwise.py
@@ -1980,6 +1980,7 @@ def test_tanh(*, dtype_and_x, complex_mode, test_flags, backend_fw, fn_name, on_
     ),
     rand_either=_either_x_dx(),
     test_gradients=st.just(False),
+    ground_truth_backend="numpy",
 )
 def test_trapz(
     dtype_values_axis, rand_either, test_flags, backend_fw, fn_name, on_device