Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing bitwise_xor method to PyTorch Frondend #13008

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Implementing bitwise_xor method to PyTorch Frondend #13008

merged 5 commits into from
Mar 24, 2023

Conversation

jatinS-dev
Copy link
Contributor

@jatinS-dev jatinS-dev commented Mar 23, 2023 •
edited by hmahmood24
Loading

Close #13007

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Mar 23, 2023
@hmahmood24
Copy link
Contributor

Hey @jatinS-dev, awesome work! I have added a few comments and requested some changes. Kindly look into those. Otherwise, everything looks good to merge! 😊

@jatinS-dev
Copy link
Contributor Author

@hmahmood24 I have done the necessary changes, you can review it now. Thank you :)

@ivy-seed ivy-seed assigned juliagsy and unassigned hmahmood24 Mar 24, 2023
@hmahmood24 hmahmood24 assigned hmahmood24 and unassigned juliagsy Mar 24, 2023
@hmahmood24
Copy link
Contributor

Thanks for the changes @jatinS-dev!

Just a small point. Kindly ensure that your PRs gets linked to the issue(s) you are trying to resolve by commenting: Close #<issue_number> as explained here. This just helps in keeping track of tasks that have been carried out and correctly closing any issues that should be closed once the PR gets merged. For now, I'll just manually link the two but in the future you should do this yourself. 😊

Thanks for a great contribution! 🚀

@hmahmood24 hmahmood24 merged commit cd28fa4 into ivy-llc:master Mar 24, 2023
RakshitKumar04 pushed a commit to RakshitKumar04/ivy that referenced this pull request Mar 27, 2023
@jatinS-dev @hmahmood24 @RakshitKumar04
Implementing bitwise_xor method to PyTorch Frondend (ivy-llc#13008)
a211e31 
Co-authored-by: hmahmood24 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmahmood24 hmahmood24 hmahmood24 approved these changes

Assignees

@hmahmood24 hmahmood24

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bitwise_xor
4 participants
@jatinS-dev @hmahmood24 @juliagsy @ivy-leaves