Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logical_and #13114

Merged
merged 4 commits into from
Mar 25, 2023
Merged

logical_and #13114

merged 4 commits into from
Mar 25, 2023

Conversation

Om-Doiphode
Copy link
Contributor

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Mar 25, 2023
@nassimberrada
Copy link
Contributor

Hi @Om-Doiphode, thank you for your contribution ! Could you also implement the testing for this function in the ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py path ? I suggest you take a look at how tests are implemented there to get an idea. Let me know when you've done that and the tests are passing then I'll give this another review. Thanks !

@Om-Doiphode
Copy link
Contributor Author

Hi @nassimberrada, I have implemented the testing for logical_and function. Please review.

nassimberrada
nassimberrada suggested changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@nassimberrada nassimberrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix needed, let me know when that's done and I should be able to merge. Thanks !

ivy/functional/frontends/torch/tensor.py Outdated Show resolved Hide resolved
@nassimberrada
Copy link
Contributor

Thanks for the quick fix, merging !

@nassimberrada nassimberrada merged commit b7e1a46 into ivy-llc:master Mar 25, 2023
RakshitKumar04 pushed a commit to RakshitKumar04/ivy that referenced this pull request Mar 27, 2023
@Om-Doiphode @RakshitKumar04
logical_and (ivy-llc#13114)
c816d51 
Co-authored by: nassimberrada
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nassimberrada nassimberrada nassimberrada requested changes

Assignees

@nassimberrada nassimberrada

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Om-Doiphode @nassimberrada @ivy-leaves