Implementing logical_or to pytorch frontend #13590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
PyTorch Frontend
ZoeCD
suggested changes
Apr 2, 2023
| @@ -3032,6 +3032,40 @@ def test_torch_instance_logical_and( | |||
| on_device=on_device, | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Just two small lint errors, but other than that LGTM! 😊
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py:3036:1: E302 expected 2 blank lines, found 1
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py:3071:1: E302 expected 2 blank lines, found 1
|
Corrected lint error as requested. |
MuhammedAshraf2020
pushed a commit
to MuhammedAshraf2020/ivy
that referenced
this pull request
Apr 9, 2023
Co-authored-by: ZoeCD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13589