-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update searching.py #1360
Update searching.py #1360
Conversation
resolves #1357 |
Hey @johanjino, please fix the linting errors in order to pass the formatting check. Add exhaustive docstring examples including instance method examples and container examples. Please refer to https://lets-unify.ai/ivy/deep_dive/11_docstring_examples.html. |
The requested documentation on containers and instance methods were added. The linting errors were removed. Please let me know if any more changes are required.
Thank you for the review. The following changes where made:
Please let me know if anything else needs to be changed. |
Hi @johanjino, ivy.Array instances will always be inplace updated consistently, in some cases it is simply not possible to also inplace update the ivy.NativeArray which ivy.Array wraps, due to design choices made by each backend. So there is one minor fix that needs to be done. Please remove ivy.NativeArray in the typehint for the out argument. Sorry for the trouble. |
Sure. Thank you again. I have made the changes. |
@johanjino, I'm sorry if there was any confusion in my explanation. What I meant is change this typehint |
I am sorry for the misunderstanding. I have restored the |
Please remove the blank line on line 62. |
Removed the blank line 62. Sorry you had to go through these small changes. |
It's alright @johanjino. Good job! |
Other than the docstring reformatting, output array was not specified in argmin(). This was observed when trying to run the function on python. Therefore, "out" typing has been specified and passed within function call.