Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jax.random.gumbel frontend #14484

Merged
merged 14 commits into from
Apr 24, 2023
Merged

add jax.random.gumbel frontend #14484

merged 14 commits into from
Apr 24, 2023

Conversation

MuhammedAshraf2020
Copy link
Contributor

@MuhammedAshraf2020 MuhammedAshraf2020 commented Apr 22, 2023 •
edited
Loading

close #14481

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Apr 22, 2023
KareemMAX
KareemMAX suggested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is just a minor change before you proceed with the final tests.

ivy/functional/frontends/jax/random.py Outdated Show resolved Hide resolved
KareemMAX
KareemMAX suggested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is not formatted correctly, please allow pre-commit to lint your code.

Also, I'm reviewing with @CatB1t the paddle and torch uint32 failing tests, I'll get back to you with the appropriate fix

@MuhammedAshraf2020
add jax.random.gumbel frontend
58710b2
@MuhammedAshraf2020
Merge remote-tracking branch 'origin/jax_gumbel' into jax_gumbel
5b4def8 
# Conflicts:
#	ivy/functional/frontends/jax/random.py
#	ivy_tests/test_ivy/test_frontends/test_jax/test_jax_random.py
@MuhammedAshraf2020
add jax.random.gumbel frontend
59ed2ab
@KareemMAX KareemMAX merged commit 0fbaaa4 into ivy-llc:master Apr 24, 2023
KareemMAX
KareemMAX reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged, thanks 😄

@MuhammedAshraf2020 MuhammedAshraf2020 deleted the jax_gumbel branch April 25, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KareemMAX KareemMAX KareemMAX requested changes

Assignees

@KareemMAX KareemMAX

Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gumbel
3 participants
@MuhammedAshraf2020 @KareemMAX @ivy-leaves