Add torch.tesnor.fmod_ function #14950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
PyTorch Frontend
sherry30
suggested changes
May 7, 2023
There was a problem hiding this comment.
Hi Paula,
Looks good for the most part, but the instance methods in torch tensor ending with _ like fmod_ are all in place methods , you can checkout other similar inplace instance methods ending with _ in this class to get an idea how they're implemented. 😄
Thanks
|
@sherry30 Sorry for this mistake I implement it but using torch_frontend.fmod because fmod function not implemented yet in torch.tensor to call it and Iadded TODO to implement this function |
paulaehab
force-pushed
the
Add--torch.Tensor.fmod_
branch
from
d9476ef
to
bdacada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14946