-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conv2d #15697
conv2d #15697
Conversation
hi, @MahmoudAshraf97 kindly review this pr :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddle already has data format argument, why not use it directly instead of the axis swap?
Yes! I initialized the data format to "NCHW". PyTorch and Paddle have this format as the default whilst Tensorflow has "NHCW" as the default data format. I changed the code to perform an axis swap once at the end. works? |
umm, since Paddle produces output consistent with the input format passed, I removed the axis swaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use the hypothesis tests to make sure your implementation is correct before requesting another review
Add Layers to Paddle Backend #10696