Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conv2d #15697

Closed
wants to merge 6 commits into from
Closed

conv2d #15697

wants to merge 6 commits into from

Conversation

rum1887
Copy link
Contributor

@rum1887 rum1887 commented May 19, 2023

Add Layers to Paddle Backend #10696

@rum1887
Copy link
Contributor Author

rum1887 commented May 19, 2023

hi, @MahmoudAshraf97 kindly review this pr :)

Copy link
Contributor

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle already has data format argument, why not use it directly instead of the axis swap?

@rum1887
Copy link
Contributor Author

rum1887 commented May 25, 2023

paddle already has data format argument, why not use it directly instead of the axis swap?

Yes!

I initialized the data format to "NCHW". PyTorch and Paddle have this format as the default whilst Tensorflow has "NHCW" as the default data format.

I changed the code to perform an axis swap once at the end.

works?

@rum1887
Copy link
Contributor Author

rum1887 commented May 25, 2023

paddle already has data format argument, why not use it directly instead of the axis swap?

Yes!

I initialized the data format to "NCHW". PyTorch, Paddle has this format as the default whilst Tensorflow has "NHCW" as the default dataformat.

I changed the code to perform axis swap once at the end.

works?

umm, since Paddle produces output consistent with the input format passed, I removed the axis swaps.

Copy link
Contributor

@MahmoudAshraf97 MahmoudAshraf97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the hypothesis tests to make sure your implementation is correct before requesting another review

ivy/functional/backends/paddle/layers.py Outdated Show resolved Hide resolved
@ivy-leaves ivy-leaves added the PaddlePaddle Backend Developing the Paddle Paddle Backend. label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PaddlePaddle Backend Developing the Paddle Paddle Backend.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants