Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added atanh function and test for PaddlePaddle frontend #15912

Closed
wants to merge 2 commits into from

Conversation

sachelsout
Copy link
Contributor

Close #15908

@nassimberrada
Copy link
Contributor

nassimberrada commented May 26, 2023

Hi @sachelsout, thank you for your contribution ! However, I think there's a mismatch between your implementation and the To-Do list in which you added your issue. You are implementing the paddle.tensor.math.atanh frontend function but the To-Do list linked to your issue concerns instance methods located in the paddle.tensor.tensor.Tensor class.

The function you currently implement is already being worked on in this issue so I suggest you make another PR where you implement the instance method as explained in the To-Do list. Otherwise feel free to work on another function but make sure you reference the appropriate list, thanks !

@sachelsout
Copy link
Contributor Author

Hi @nassimberrada, apologies on my end, I executed atanh function (tensor.math) for tensor.tensor related issue. Thank you for explaining in brief. 😊
I have a doubt though. There's an issue #15802 for adding asin function in tensor.tensor related issues but the person has executed asin for tensor.math related issue in math.py.
Could you please let me know if I'm missing something.

Thank you.

@sachelsout
Copy link
Contributor Author

Hi @nassimberrada, apologies on my end, I executed atanh function (tensor.math) for tensor.tensor related issue. Thank you for explaining in brief. 😊
I have a doubt though. There's an issue #15802 for adding asin function in tensor.tensor related issues but the person has executed asin for tensor.math related issue in math.py.
Could you please let me know if I'm missing something.

Thank you.

The pull request associated with that issue is merged as well.

@nassimberrada
Copy link
Contributor

No worries ! My guess would be that there was a mistake there because there's a separate To-Do list for paddle.tensor.math function here. There is an on-going issue for asin in that list but as you can see the PR linked to that issue was closed because the function was already implemented. Hope this makes sense !

@sachelsout
Copy link
Contributor Author

No worries ! My guess would be that there was a mistake there because there's a separate To-Do list for paddle.tensor.math function here. There is an on-going issue for asin in that list but as you can see the PR linked to that issue was closed because the function was already implemented. Hope this makes sense !

Thank you for the clarification 😊 Much appreciated 👍🏻

@sachelsout sachelsout deleted the paddle_atanh branch May 31, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atanh
2 participants