Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tan function and test in paddle.tensor.math for paddlepaddle frontend #15931

Merged
merged 7 commits into from
Jun 17, 2023
Merged

Added tan function and test in paddle.tensor.math for paddlepaddle frontend #15931

merged 7 commits into from
Jun 17, 2023

Conversation

sachelsout
Copy link
Contributor

Close #15915

@sachelsout
Copy link
Contributor Author

Hello @suvadityamuk , could you please review my PR. :)

fnhirwa
fnhirwa suggested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey would you resolve the merge conflicts

@sachelsout sachelsout requested a review from fnhirwa June 16, 2023 15:43
fnhirwa
fnhirwa approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me😊

Thanks for contributing

@fnhirwa fnhirwa merged commit 0d4e6dc into ivy-llc:master Jun 17, 2023
@sachelsout
Copy link
Contributor Author

Looks good to me😊

Thanks for contributing

Thank you for reviewing and merging ❤️

@sachelsout sachelsout deleted the paddle_tensor_math_tan branch June 17, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa approved these changes

Assignees

@suvadityamuk suvadityamuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tan
3 participants
@sachelsout @fnhirwa @suvadityamuk