Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'add', 'subtract', 'multiply' to paddle frontend Math #15998

Merged
merged 25 commits into from
May 30, 2023
Merged

Added 'add', 'subtract', 'multiply' to paddle frontend Math #15998

merged 25 commits into from
May 30, 2023

Conversation

NripeshN
Copy link
Contributor

@NripeshN NripeshN commented May 29, 2023

@NripeshN NripeshN changed the title Add multiply to padde frontend and MacOS M1 optional file fix Add multiply to padde frontend May 29, 2023
@NripeshN NripeshN changed the title Add multiply to padde frontend Add multiply to padde frontend Math May 29, 2023
@NripeshN NripeshN changed the title Add multiply to padde frontend Math Add multiply and add to padde frontend Math May 29, 2023
@NripeshN NripeshN changed the title Add multiply and add to padde frontend Math Added 'add', 'subtract', 'multiply' to padde frontend Math May 29, 2023
@Daniel4078 Daniel4078 added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label May 29, 2023
@ivy-llc ivy-llc deleted a comment from NripeshN May 29, 2023
@ivy-llc ivy-llc deleted a comment from NripeshN May 29, 2023
This was linked to issues May 29, 2023
@NripeshN NripeshN changed the title Added 'add', 'subtract', 'multiply' to padde frontend Math Added 'add', 'subtract', 'multiply' to paddle frontend Math May 29, 2023
@NripeshN
Copy link
Contributor Author

NripeshN commented May 29, 2023

Frontend Task Checklist

IMPORTANT NOTICE 🚨:

The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.

LEGEND 🗺:

  • ❌ : Check item is not completed.
  • ✅ : Check item is ready for review.
  • 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
  • ⏩ : Check is not applicable to function (skip).
  • 🆗 : Check item is implemented and does not require any edits.

CHECKS 📑:

    • ✅: The function/method definition is not missing any of the original arguments.
    • 🆘: In case the function/method to be implemented is an alias of an existing function/method:
        • ✅ : It is being declared as such by setting fun1 = fun2, rather than being re-implemented from scratch.
        • ✅ : The alias is added to the existing function/method's test in the aliases parameter of handle_frontend_test/handle_frontend_method.
    • ✅: The naming of the function/method and its arguments exactly matches the original.
    • ✅ : No defined argument is being ignored in the function/method's implementation.
    • ⏩ : In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
        • ⏩ : A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
    • ✅ : In case a frontend function is being added:
        • ✅ : It is a composition of ivy functions.
        • ⏩ : In case the needed composition is long (using numerous ivy functions), a Missing Function Suggestion issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
        • ✅ : @to_ivy_arrays_and_back has been added to the function.
    • ✅ : In case a frontend method is being added:
        • ⏩ : It is composed of existing frontend functions or methods.
        • ✅ : If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
          • ✅ : @to_ivy_arrays_and_back has been added to the method.
          • ⏩ : A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
    • ✅ : The function/method's test has been added (except in the alias case mentioned in <2>):
        • ✅ : All supported arguments are being generated in handle_frontend_test/handle_frontend_method and passed to test_frontend_function/test_frontend_method.
        • ✅ : The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
        • ✅ : The available_dtypes parameter passed to the helper generating the function/method's input array is set to helpers.get_dtypes("valid"). If there are unsupported dtypes that cause the test to fail, they should be handled by adding @with_supported_dtypes/@with_unsupported_dtype to the function/method.
    • 🆘: The PR is not introducing any test failures.
        • 🆘: The lint checks are passing.
        • 🆘: The implemented test is passing for all backends.
    • ✅: The PR closes a Sub Task issue linked to one of the open frontend ToDo lists.
    • ✅: The function/method and its test have been added to the correct .py files corresponding to the addressed ToDo list.
    • ✅: The PR only contains changes relevant to the addressed subtask.

Copy link
Contributor

@Daniel4078 Daniel4078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try resolve the merge conflicts in the test_paddle_math file? Everything else is pretty good now, Thanks.

@NripeshN
Copy link
Contributor Author

Can you try resolve the merge conflicts in the test_paddle_math file? Everything else is pretty good now, Thanks.

Merge conflicts resolved now

@NripeshN NripeshN requested a review from Daniel4078 May 30, 2023 08:47
Copy link
Contributor

@Daniel4078 Daniel4078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@Daniel4078 Daniel4078 merged commit ad79649 into ivy-llc:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subtract add multiply
2 participants