-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addr_ #16033
addr_ #16033
Conversation
Hey @nathzi1505 ImportError while loading conftest 'C:\Users\EL-Huda\ivy\ivy_tests\test_ivy\conftest.py'. help me ! |
I implement the function correctly, but I don't know where is the error. @nathzi1505 |
Hi @a00ayad00, not quite sure about Windows system tbh. |
Not quite sure how I can help. There seems to be a problem with the imports. |
@nathzi1505 I already did that and I start from the beginning, but the same problem happens. |
@nathzi1505 But the main issue is that I don't understand where are the error cuz I just implemented the same function that was merged already. Do you understand me ?! |
Yes, windows 11. |
Hi @nathzi1505 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a push and fixed the test. The config related test is specific to you local setup @a00ayad00
I have updated the sig according to https://pytorch.org/docs/stable/generated/torch.Tensor.addr_.html and ensured test is passing. Previously kw args were being passed which the method did not even have.
LGTM but @nathzi1505 Feel free to merge when you think everythings in order.
Thanks.
But I just implemented that like the other functions, they didn't pass the kws at all !!! But any way, I would like to thank you very much @Ishticode 💚❤️🌹 |
You can merge that too cuz you are assigned to me too @Ishticode |
Close #15859