Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addr_ #16033

Merged
merged 3 commits into from
Jun 2, 2023
Merged

addr_ #16033

merged 3 commits into from
Jun 2, 2023

Conversation

a00ayad00
Copy link
Contributor

Close #15859

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label May 29, 2023
@a00ayad00
Copy link
Contributor Author

Hey @nathzi1505
I had an error on my local test bellow and I can't understand it !!

ImportError while loading conftest 'C:\Users\EL-Huda\ivy\ivy_tests\test_ivy\conftest.py'.
ivy_tests\test_ivy_init_.py:1: in
from .. import config
E ImportError: cannot import name 'config' from 'ivy_tests' (C:\Users\EL-Huda\ivy\ivy_tests_init_.py)

help me !

@a00ayad00
Copy link
Contributor Author

I implement the function correctly, but I don't know where is the error. @nathzi1505
It's the addr_ function and I implemented the addr function before and it was merged !!

@p3jitnath
Copy link
Contributor

Hi @a00ayad00, not quite sure about Windows system tbh.
Can you take a clean clone of the repository and try again?

@p3jitnath
Copy link
Contributor

Not quite sure how I can help. There seems to be a problem with the imports.
@Ishticode can you look at this problem as I understand your main system is Windows based?

@a00ayad00
Copy link
Contributor Author

Hi @a00ayad00, not quite sure about Windows system tbh. Can you take a clean clone of the repository and try again?

@nathzi1505 I already did that and I start from the beginning, but the same problem happens.

@a00ayad00
Copy link
Contributor Author

Hi @a00ayad00, not quite sure about Windows system tbh. Can you take a clean clone of the repository and try again?

@nathzi1505 I already did that and I start from the beginning, but the same problem happens.

@nathzi1505 But the main issue is that I don't understand where are the error cuz I just implemented the same function that was merged already. Do you understand me ?!

@a00ayad00
Copy link
Contributor Author

a00ayad00 commented May 30, 2023

Not quite sure how I can help. There seems to be a problem with the imports. @Ishticode can you look at this problem as I understand your main system is Windows based?

Yes, windows 11.
But I implemented many functions before successfully and I don't know what happened this time !!

@Ishticode
Copy link
Contributor

Not quite sure how I can help. There seems to be a problem with the imports. @Ishticode can you look at this problem as I understand your main system is Windows based?

Hi @nathzi1505
Ive been on linux for a while now so not sure i could help much with windows related issue. I can take a look anyways perhaps tomorrow.

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a push and fixed the test. The config related test is specific to you local setup @a00ayad00
I have updated the sig according to https://pytorch.org/docs/stable/generated/torch.Tensor.addr_.html and ensured test is passing. Previously kw args were being passed which the method did not even have.

LGTM but @nathzi1505 Feel free to merge when you think everythings in order.
Thanks.

@a00ayad00
Copy link
Contributor Author

I've made a push and fixed the test. The config related test is specific to you local setup @a00ayad00 I have updated the sig according to https://pytorch.org/docs/stable/generated/torch.Tensor.addr_.html and ensured test is passing. Previously kw args were being passed which the method did not even have.

LGTM but @nathzi1505 Feel free to merge when you think everythings in order. Thanks.

But I just implemented that like the other functions, they didn't pass the kws at all !!!
Maybe there is, all the functions I saw didn't pass their kws !!

But any way, I would like to thank you very much @Ishticode 💚❤️🌹

@a00ayad00
Copy link
Contributor Author

You can merge that too cuz you are assigned to me too @Ishticode
Anyone who see this comment before the other, you can merge the commit 😅 @nathzi1505

@a00ayad00 a00ayad00 requested a review from Ishticode May 31, 2023 13:12
@p3jitnath p3jitnath merged commit 71d187a into ivy-llc:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addr_
4 participants