Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added less_than function and test to Paddle frontend #16164

Closed
wants to merge 2 commits into from

Conversation

a1701s
Copy link

@a1701s a1701s commented Jun 2, 2023

No description provided.

@a1701s
Copy link
Author

a1701s commented Jun 2, 2023

#15115 added less_than function

Copy link
Contributor

@Aarsh2001 Aarsh2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @a1701s, you are supposed to add these functions as instance methods in the paddle.tensor.tensor.Tensor class. Also, there doesn't exist any ivy.less_than function in the functional API. Please make the suggested changes, and re-request a review from me, thanks 🙂

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jun 19, 2023
@ivy-seed ivy-seed added the Stale label Jun 20, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@Aarsh2001
Copy link
Contributor

Feel free to reopen once you're done with your changes thanks

@Aarsh2001 Aarsh2001 closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants