Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: "add_" in paddle.tensor.tensor.Tensor #16653

Merged
merged 8 commits into from
Jun 14, 2023

Conversation

AayushMohan
Copy link
Contributor

No description provided.

@AayushMohan AayushMohan reopened this Jun 13, 2023
@AayushMohan
Copy link
Contributor Author

#16643

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Jun 13, 2023
Copy link
Contributor

@Fayad-Alman Fayad-Alman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AayushMohan, all looks good so far, just fix the current conflict in the tensor.py file and request another review!

@AayushMohan
Copy link
Contributor Author

Hey @Fayad-Alman, I have fixed all the issues can you please merge it?

Copy link
Contributor

@Fayad-Alman Fayad-Alman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fayad-Alman Fayad-Alman merged commit 7536922 into ivy-llc:master Jun 14, 2023
@Ishticode
Copy link
Contributor

@Fayad-Alman ivy.add_ used here does not even exist in the ivy api. Were the tests ran before merging this?

@Fayad-Alman
Copy link
Contributor

@Ishticode Sorry about that, I didn't even notice, I'll fix that right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants