Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented fft in paddle #16688

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Implemented fft in paddle #16688

merged 4 commits into from
Jun 19, 2023

Conversation

KevinUli
Copy link
Contributor

@KevinUli KevinUli commented Jun 14, 2023 •
edited
Loading

Close #16684

xoiga123
xoiga123 suggested changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@xoiga123 xoiga123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the test more generalized a bit 💪

ivy_tests/test_ivy/test_frontends/test_paddle/test_paddle_fft.py Outdated Show resolved Hide resolved
@KevinUli KevinUli requested a review from xoiga123 June 15, 2023 05:59
xoiga123
xoiga123 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@xoiga123 xoiga123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KevinUli 👏

@xoiga123 xoiga123 merged commit a22d0f1 into ivy-llc:master Jun 19, 2023
@KevinUli KevinUli deleted the paddle.fft branch June 19, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoiga123 xoiga123 xoiga123 approved these changes

Assignees

@xoiga123 xoiga123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fft
2 participants
@KevinUli @xoiga123