Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added amin #17548

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Added amin #17548

merged 5 commits into from
Jun 22, 2023

Conversation

AkshayVenkataraman
Copy link
Contributor

Close #17547

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jun 22, 2023
sherry30
sherry30 suggested changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change requested,
Can you also fix the lint errors.

Thanks

ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_paddle_tensor.py Outdated
init_tree="paddle.to_tensor",
method_name="amin",
dtype_x_axis=helpers.dtype_values_axis(
available_dtypes=st.one_of(helpers.get_dtypes("float", "int")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can put numeric in the get_dtypes method and add complex as unsupported dtypes if they are not supported

@MuhammadSaeedBatikh MuhammadSaeedBatikh merged commit ce8daac into ivy-llc:master Jun 22, 2023
@MuhammadNizamani
Copy link
Contributor

@sherry30 @MuhammadSaeedBatikh function amin has not been implemented in paddle back-end so before merging this PR, someone need to implement in amin in paddle back-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 sherry30 requested changes

Assignees

@sherry30 sherry30

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amin
5 participants
@AkshayVenkataraman @MuhammadNizamani @sherry30 @MuhammadSaeedBatikh @ivy-leaves