EHN: logical_or added in paddle tesnor.py #17615
Conversation
ivy-leaves
added
the
Paddle Frontend
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
| "paddle", | ||
| ) | ||
| def logical_or(self, y, out=None, name=None): | ||
| y_ivy = _to_ivy_array(y) |
There was a problem hiding this comment.
You need to wrap the variables explicitly for frontend functions.
There was a problem hiding this comment.
could please you explain why do I need wrap the variables explicitly for frontend functions?
_to_ivy_array(y) convert it into ivy_array
There was a problem hiding this comment.
@Dsantra92 are you talking about this way to implemet the function ?
def logical_or(self, y, out=None, name=None):
return paddle_frontend.logical_or(self, y, out=out)
There was a problem hiding this comment.
@Dsantra92 are you talking about this way to implemet the function ?
def logical_or(self, y, out=None, name=None): return paddle_frontend.logical_or(self, y, out=out)
Yeah, this is what @Dsantra92 meant probably.
|
Hey @MuhammadNizamani 🙂, I will link this to the corresponding issue, but in future you should do this yourself by adding a comment ‘Close #Issue_number’, as explained here. |
|
@bipinKrishnan ok sir got it |
|
LGTM! Thanks @MuhammadNizamani 🚀 |
Co-authored-by: bipinkrishnan <[email protected]> Co-authored-by: Deeptendu <[email protected]>
Logical_or is added in paddle.tesnor.tesnor.Tensor from issue #17596