Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding jax_random_orthogonal #17981

Closed
wants to merge 1 commit into from

Conversation

stalemate1
Copy link
Contributor

No description provided.

@Ookamice
Copy link
Contributor

@stalemate1
Hiya, thank you for your contributions. Could you please double check the contributor's guide regarding how to open an PR for a frontend function.

Namely, please reference the issue number that this PR relates to and double check that the files in this PR are in the same directory. There shouldn't be a case of creating new files with PRs of this type.

Let me know if you have any other questions or concerns! 😃

@stalemate1
Copy link
Contributor Author

orthogonal #17774

@stalemate1
Copy link
Contributor Author

It is being placed in the appropriate directory (I believe). Also, I have mentioned the issue number in the comment. Should I be worried about anything else before the workflow is approved?

@Ookamice
Copy link
Contributor

@stalemate1
Hiya, please double check that the directory is correct. Currently, as according to the "files changed" tab of this PR, it is showing that you're trying to add 2 files into the root directory of Ivy. Rather, it should look like you're trying to modify two files in the respective frontend subdirectories.

Let me know if you need further help in this matter. 😸

@stalemate1
Copy link
Contributor Author

@Ookamice , sorry unfortunately whatever I have been updating on git bash is not being reflected on github. Therefore, I copied the entire file and pasted here and that was the problem. Now I have created a new PR Orthogonal #18094. Please let me know if it is fine.

Thanks a bunch!

@Ookamice
Copy link
Contributor

Sounds good 👍

I'll close this PR for you and good luck on your next PR

@Ookamice Ookamice closed this Jun 30, 2023
@stalemate1 stalemate1 deleted the for_orthogonal branch July 18, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants