Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paddle smooth l1 loss implementation to frontend and test #18925

Merged
merged 9 commits into from
Jul 14, 2023

Conversation

peterwisu
Copy link
Contributor

Close #18373

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jul 6, 2023
Wish Suharitdamrong added 2 commits July 7, 2023 11:15
…loss

# Conflicts:
#	ivy/functional/frontends/paddle/nn/functional/loss.py
#	ivy_tests/test_ivy/test_frontends/test_paddle/test_nn/test_functional/test_paddle_loss.py
@iamjameskeane
Copy link
Contributor

iamjameskeane commented Jul 9, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@peterwisu
Copy link
Contributor Author

@jkeane508 I have pulled a fork. Is this PR ready to merge?

@iamjameskeane
Copy link
Contributor

@jkeane508 I have pulled a fork. Is this PR ready to merge?

Yep ready to merge, just need you to resolve conflicts :)

@peterwisu peterwisu closed this Jul 12, 2023
@peterwisu peterwisu force-pushed the paddle_smooth_l1_loss branch 2 times, most recently from 9b2ec6f to 9d81e47 Compare July 12, 2023 13:48
@peterwisu peterwisu reopened this Jul 12, 2023
@iamjameskeane iamjameskeane merged commit dc0490d into ivy-llc:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

smooth_l1_loss
3 participants