Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pad paddle frontend nn common.py #19346

Closed
wants to merge 20 commits into from
Closed

Add pad paddle frontend nn common.py #19346

wants to merge 20 commits into from

Conversation

NripeshN
Copy link
Contributor

Close #19342

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jul 13, 2023
@NripeshN
Copy link
Contributor Author

NripeshN commented Jul 13, 2023

Frontend Task Checklist

IMPORTANT NOTICE 🚨:

The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process.

Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂

LEGEND 🗺:

  • ❌ : Check item is not completed.
  • ✅ : Check item is ready for review.
  • 🆘 : Stuck/Doubting implementation (PR author should add comments explaining why).
  • ⏩ : Check is not applicable to function (skip).
  • 🆗 : Check item is implemented and does not require any edits.

CHECKS 📑:

    • ✅: The function/method definition is not missing any of the original arguments.
    • ✅: In case the function/method to be implemented is an alias of an existing function/method:
        • ✅: It is being declared as such by setting fun1 = fun2, rather than being re-implemented from scratch.
        • ✅: The alias is added to the existing function/method's test in the aliases parameter of handle_frontend_test/handle_frontend_method.
    • ✅: The naming of the function/method and its arguments exactly matches the original.
    • ✅: No defined argument is being ignored in the function/method's implementation.
    • ✅: In special cases where an argument's implementation should be pending due to an incomplete superset of an ivy function:
        • ⏩: A ToDo comment has been added prompting to pass the frontend argument to the ivy function whose behavior is to be extended.
    • ✅: In case a frontend function is being added:
        • ✅: It is a composition of ivy functions.
        • ⏩: In case the needed composition is long (using numerous ivy functions), a Missing Function Suggestion issue has been opened to suggest a new ivy function should be added to shorten the frontend implementation.
        • ✅: @to_ivy_arrays_and_back has been added to the function.
    • ✅: In case a frontend method is being added:
        • ✅: It is composed of existing frontend functions or methods.
        • ✅: If a required frontend function has not yet been added, the method may be implemented as a composition of ivy functions, making sure that:
          • ✅: @to_ivy_arrays_and_back has been added to the method.
          • ⏩: A ToDo comment has been made prompting to remove the decorator and update the implementation as soon as the missing function has been added.
    • 🆘: The function/method's test has been added (except in the alias case mentioned in <2>):
        • 🆘: All supported arguments are being generated in handle_frontend_test/handle_frontend_method and passed to test_frontend_function/test_frontend_method.
        • 🆘: The argument generation covers all possible supported values. Array sizes, dimensions, and axes adhere to the full supported set of the original function/method.
        • 🆘: The available_dtypes parameter passed to the helper generating the function/method's input array is set to helpers.get_dtypes("valid"). If there are unsupported dtypes that cause the test to fail, they should be handled by adding @with_supported_dtypes/@with_unsupported_dtype to the function/method.
    • 🆘: The PR is not introducing any test failures.
        • ✅: The lint checks are passing.
        • 🆘: The implemented test is passing for all backends.
    • ✅: The PR closes a Sub Task issue linked to one of the open frontend ToDo lists.
    • ✅: The function/method and its test have been added to the correct .py files corresponding to the addressed ToDo list.
    • ✅: The PR only contains changes relevant to the addressed subtask.

@RickSanchezStoic
Copy link
Contributor

Hi @NripeshN can you try resolving the merge conflicts?

@NripeshN
Copy link
Contributor Author

NripeshN commented Jul 19, 2023

Hi @NripeshN can you try resolving the merge conflicts?

Hi @RickSanchezStoic Merge conflicts have been resolved now

@RickSanchezStoic
Copy link
Contributor

@NripeshN Can you go through and resolve the test errors that you are seeing in intelligent-tests-pr / run_tests (1) (pull_request) ? Thanks

@NripeshN
Copy link
Contributor Author

@NripeshN Can you go through and resolve the test errors that you are seeing in intelligent-tests-pr / run_tests (1) (pull_request) ? Thanks

@RickSanchezStoic Could you please review the test now? It's giving some module not found error and I'm not sure how to fix it.

@RickSanchezStoic
Copy link
Contributor

RickSanchezStoic commented Jul 25, 2023

@CatB1t Any ideas why this import error is occurring? Meanwhile, @NripeshN can you try updating your fork and getting the latest changes from master?

@RickSanchezStoic
Copy link
Contributor

Hey Nripesh, can you fix the merge conflicts?

@RickSanchezStoic
Copy link
Contributor

Hey @NripeshN the function is missing an argument data_format='NCHW' the errors seem to be related to that.

@ivy-seed ivy-seed added the Stale label Aug 21, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@NripeshN NripeshN closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pad
5 participants