-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
affine_grid #18942 #19371
affine_grid #18942 #19371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @so-dipe
Thanks for the PR 😊
Your changes looks good🙂 however, the tests are only passing for the Numpy
and Jax
backends would you look into this disparity?
Thanks
Hi... My changes are in line with the affine_grid function in pytorch and they seem to be failing the same tests too. I think there's a general issue with the ivy implementation of some functions used there. I not sure which of the functions is causing the issue, and i didn't bother to check because I didn't think editing it would be in the cope of the issue. |
Hi again @hirwa-nshuti |
Hello @hirwa-nshuti, I have made some changes and I need you to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @so-dipe
Good progress with this item.
Now the failure is remaining with the paddle backend
it's a flaky test error... what am i going to do about that.🤷🏽♂️ @hirwa-nshuti |
@hirwa-nshuti This is the issue. My code passes the test but fails it initially, there's nothing I can do about that. It's probably an error caused by another function or something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Going to merge it we will look into the detailed issue😊
Close #18942