Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

affine_grid #18942 #19371

Merged
merged 3 commits into from
Jul 21, 2023
Merged

affine_grid #18942 #19371

merged 3 commits into from
Jul 21, 2023

Conversation

so-dipe
Copy link
Contributor

@so-dipe so-dipe commented Jul 13, 2023

Close #18942

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jul 13, 2023
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @so-dipe

Thanks for the PR 😊
Your changes looks good🙂 however, the tests are only passing for the Numpy and Jax backends would you look into this disparity?

Thanks

@so-dipe
Copy link
Contributor Author

so-dipe commented Jul 14, 2023

Hi...

My changes are in line with the affine_grid function in pytorch and they seem to be failing the same tests too. I think there's a general issue with the ivy implementation of some functions used there. I not sure which of the functions is causing the issue, and i didn't bother to check because I didn't think editing it would be in the cope of the issue.

@so-dipe
Copy link
Contributor Author

so-dipe commented Jul 14, 2023

Hi again @hirwa-nshuti
I suspect the problem is coming from here base_grid[:, :, :, 1] = ivy.expand_dims( ivy.linspace(-1, 1, H) * (H - 1) / H, axis=-1 ) numpy and jax handle the casting differently from the other frameworks

@so-dipe
Copy link
Contributor Author

so-dipe commented Jul 15, 2023

Hello @hirwa-nshuti, I have made some changes and I need you to take a look.

@so-dipe so-dipe requested a review from fnhirwa July 15, 2023 20:29
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @so-dipe

Good progress with this item.
Now the failure is remaining with the paddle backend
image

@so-dipe
Copy link
Contributor Author

so-dipe commented Jul 18, 2023

it's a flaky test error... what am i going to do about that.🤷🏽‍♂️ @hirwa-nshuti

@so-dipe
Copy link
Contributor Author

so-dipe commented Jul 19, 2023

@hirwa-nshuti This is the issue. My code passes the test but fails it initially, there's nothing I can do about that. It's probably an error caused by another function or something.
Screenshot from 2023-07-19 14-12-05

@so-dipe so-dipe requested a review from fnhirwa July 19, 2023 13:14
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Going to merge it we will look into the detailed issue😊

@fnhirwa fnhirwa merged commit 61f9234 into ivy-llc:master Jul 21, 2023
@so-dipe so-dipe deleted the paddle_affine_grid branch July 21, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

affine_grid
3 participants