Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instance Methods to PyTorch Frontend #3612 - sinc #21142 #21144

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Add Instance Methods to PyTorch Frontend #3612 - sinc #21142 #21144

merged 3 commits into from
Aug 14, 2023

Conversation

alexkoziell
Copy link
Contributor

Close #21142

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 1, 2023
@theRealBird
Copy link
Contributor

Hi @alexkoziell
Thank you for your patience and for contributing to Ivy. Great work on the PR, looks good to me!
Before it can be merged, could you please resolve the merge conflicts?
Thanks!

@alexkoziell
Copy link
Contributor Author

@theRealBird Have fixed the merge conflicts! Please may you double-check everything is still working?

@theRealBird
Copy link
Contributor

Hi @alexkoziell,
Everything looks great! I was OOO yesterday so could not merge your PR in time, can you please remove the conflicts once more? Thanks!

@alexkoziell
Copy link
Contributor Author

alexkoziell commented Aug 14, 2023 •
edited
Loading

@theRealBird Updated again! Will still feel more confident after a double-check from you :)

@theRealBird
Copy link
Contributor

Hi @alexkoziell,
Thanks for resolving the conflicts. At the moment on the tests dashboard, I see a lot of new failures being introduced via this PR, but none seem to be related to your change. Things look good to me. Thanks!

@theRealBird theRealBird merged commit 35f36db into ivy-llc:main Aug 14, 2023
79 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theRealBird theRealBird

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sinc
3 participants
@alexkoziell @theRealBird @ivy-leaves