Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor frontend testing config #21570

Merged
merged 22 commits into from
Aug 16, 2023
Merged

Refactor frontend testing config #21570

merged 22 commits into from
Aug 16, 2023

Conversation

CatB1t
Copy link
Contributor

@CatB1t CatB1t commented Aug 10, 2023 •
edited
Loading

  • Added SupportedDtypes and SupportedDevices dataclasses, currently they're only a place holder instead of multiple attributes, for the future reference it should compute all parameters from a single valid_dtypes and valid_devices lists respectively.
  • Added FrontendConfig and FrontendConfigWithBackend classes, the first holds the same legacy information as before but will throw an exception if one is missing, the later is used for frontends that have a backend implemented, to reduce code redundancy.
  • Refactored numpy, tensorflow, torch, jax and paddle configs to use FrontendConfigWithBackend
  • Refactored mxnet, onnx, scipy and pandas frontend configs to use FrontendConfig

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@CatB1t CatB1t requested a review from sherry30 August 15, 2023 10:10
@CatB1t CatB1t marked this pull request as ready for review August 15, 2023 10:14
sherry30
sherry30 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CatB1t CatB1t merged commit 287552b into ivy-llc:main Aug 16, 2023
75 of 266 checks passed
sushmanthreddy pushed a commit to sushmanthreddy/ivy that referenced this pull request Aug 17, 2023
@CatB1t @sushmanthreddy
Refactor frontend testing config (ivy-llc#21570)
072ccd4 
- Added `SupportedDtypes` and `SupportedDevices` dataclasses, currently they're only a place holder instead of multiple attributes, for the future reference it should compute all parameters from a single `valid_dtypes` and `valid_devices` lists respectively.
- Added `FrontendConfig` and `FrontendConfigWithBackend` classes, the first holds the same legacy information as before but will throw an exception if one is missing, the later is used for frontends that have a backend implemented, to reduce code redundancy.
- Refactored `numpy`, `tensorflow`, `torch`, `jax` and `paddle` configs to use `FrontendConfigWithBackend`
- Refactored `mxnet`, `onnx`, `scipy` and `pandas` frontend configs to use `FrontendConfig`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherry30 sherry30 sherry30 approved these changes

Assignees

@djl11 djl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CatB1t @sherry30 @djl11