Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lcm_ #21626

Closed
wants to merge 2 commits into from
Closed

lcm_ #21626

wants to merge 2 commits into from

Conversation

NiteshK84
Copy link
Contributor

Closes #21625

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@NiteshK84
Copy link
Contributor Author

image
image

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 10, 2023
@ivy-seed ivy-seed assigned Dsantra92 and theRealBird and unassigned Dsantra92 Aug 11, 2023
@theRealBird
Copy link
Contributor

theRealBird commented Aug 14, 2023

Thank you for your contribution to Ivy! Can you please resolve the merge conflicts so that your PR can be merged?

@NiteshK84
Copy link
Contributor Author

Hi @theRealBird,
I have fixed the conflicts,
please feel free to merge it.
thanks.

@theRealBird
Copy link
Contributor

@NiteshK84 Thanks for resolving the conflicts Nitesh. For some reason, your PR is introducing a lot of new failures (unrelated to your changes). Seems like there is a bug with the CI testing but could you please take a look once too? Thanks!

@NiteshK84
Copy link
Contributor Author

NiteshK84 commented Aug 23, 2023

Hey @theRealBird, I have fixed the conflicts, but
There are 2 new lint test failing from other contributions:
image

First lint
image

Another
image

I have not fixed these since they didn't belong to me, but for sure they will cause the CI lint test to fail, please tell me weather should i fix theme or not?
thanks

@theRealBird
Copy link
Contributor

image
Hi @NiteshK84,
Thanks for the great work on the PR. Yes you are not required to fix anything that you did not write.
I see some failures of LCM too, could you please take a look. Thanks!

@NiteshK84
Copy link
Contributor Author

Hey @theRealBird, i fixed all the failures,
its ready to review now,
Thanks

@NiteshK84 NiteshK84 closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lcm_
4 participants