feat(frontend): Added logsumexp function in paddlepaddle frontend #21725

shaby112 · 2023-08-11T15:38:03Z

github-actions · 2023-08-11T15:38:21Z

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

ivy-leaves · 2023-08-11T16:00:02Z

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

AryanSharma21

Hey @shaby112 , you should edit the description of the PR to add the closing tag as
close #issue_number to link the PR with the issue that you create. This will close the issue with the pull request accordingly. Thanks

shaby112 · 2023-08-12T10:38:20Z

Okay, I have edited the description. Thank you for letting me know!

sagewhocodes · 2023-08-14T08:23:21Z

ivy/functional/frontends/paddle/tensor/math.py

+
+
+@with_supported_dtypes(
+    {"2.5.1 and below": ("float32", "float64")}, "paddle"


x (Tensor) – The input Tensor with data type float16, float32 or float64, which have no more than 4 dimensions.

Original function supports the following dtypes for x, please update the decorator

Acknowledged. The changes have been made.

sagewhocodes · 2023-08-14T11:50:01Z

@shaby112 I noticed that you wrote a frontend for logsumexp but there's no implementation of that in Ivy's functional API which you were trying to use in your frontend implemenation.

I would advice you to adapt a compositional implementation similar to the one in jax's frontend for this function.
Thanks!

shaby112 · 2023-08-14T15:25:44Z

@shaby112 I noticed that you wrote a frontend for logsumexp but there's no implementation of that in Ivy's functional API which you were trying to use in your frontend implemenation.

I would advice you to adapt a compositional implementation similar to the one in jax's frontend for this function. Thanks!

Sure I will try my best

shaby112

I have changed the implementation, kindly review this.

shaby112 · 2023-08-14T10:02:21Z

ivy/functional/frontends/paddle/tensor/math.py

+
+
+@with_supported_dtypes(
+    {"2.5.1 and below": ("float32", "float64")}, "paddle"


Acknowledged. The changes have been made.

shaby112

I had some errors in the previous code that I submitted, I didn't test it properly. This implementation works as expected and passes al 5 tests aswell. Kindly review this.

shaby112

Kindly review this pull request. I would appreciate your valuable insights and thoughts!

sagewhocodes · 2023-08-18T08:21:26Z

Hi @shaby112 , Could you please resolve the merge conflicts?
I'll review them after that!

sagewhocodes · 2023-08-18T09:34:15Z

ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_math.py

 @handle_frontend_test(
-    fn_tree="paddle.tensor.math.amax",
+    fn_tree="paddle.tensor.math.logsumexp",
    dtype_and_x=helpers.dtype_and_values(
        available_dtypes=helpers.get_dtypes("valid"),
        num_arrays=2,
        allow_inf=False,
        shared_dtype=True,


add max_num_dims = 4 in the decorator , tests are failing because of it
On the paddle docs it says

x (Tensor) – The input Tensor with data type float16, float32 or float64, which have no more than 4 dimensions.

sagewhocodes · 2023-08-18T09:37:50Z

ivy/functional/frontends/paddle/tensor/math.py

+    return out
+
+
+ @with_supported_dtypes(


fix Indentation issues on Line 495

Okay, I am doing that. Thank you for letting me know!

I fixed the indentation issue however I am still getting the same lint error, I apologize for taking so much of your time.

sagewhocodes · 2023-08-18T09:39:16Z

Hello @shaby112 , Please update your PR with the proposed changes, Verify all the tests pass and let me know!

Thanks!

shaby112 · 2023-08-18T09:42:49Z

Hello @shaby112 , Please update your PR with the proposed changes, Verify all the tests pass and let me know!

Thanks!

Alright, the tests are running I will let you know how it goes. Thanks!

shaby112 · 2023-09-01T14:48:10Z

@saeedashrraf can you kindly review this? I will appreciate your input and insights.

shaby112 · 2023-09-05T18:15:26Z

@sagewhocodes can you kindly review this PR, I will greatly appreciate your insights.

shaby112 · 2023-09-20T15:45:48Z

I closed it accidentally, reopening the PR!

shaby112 · 2023-09-20T15:46:56Z

Can you kindly review this @sagewhocodes @saeedashrraf ? I will greatly appreciate your insights!

github-actions · 2023-10-21T09:05:45Z

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

NripeshN · 2024-01-02T19:33:13Z

LGTM!!

ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 11, 2023

AryanSharma21 reviewed Aug 11, 2023

View reviewed changes

ivy-seed assigned sagewhocodes Aug 11, 2023

sagewhocodes suggested changes Aug 14, 2023

View reviewed changes

shaby112 commented Aug 14, 2023

View reviewed changes

shaby112 commented Aug 16, 2023

View reviewed changes

shaby112 requested a review from sagewhocodes August 17, 2023 10:22

sagewhocodes suggested changes Aug 18, 2023

View reviewed changes

shaby112 requested a review from sagewhocodes August 18, 2023 19:32

ivy-seed assigned saeedashrraf and unassigned sagewhocodes Aug 28, 2023

shaby112 closed this Sep 20, 2023

shaby112 force-pushed the master branch from 4aff382 to 32e99bb Compare September 20, 2023 12:01

shaby112 added 2 commits September 20, 2023 20:44

Update math.py -- revised

d1bd78d

Update test_math.py -- revised

396bbbc

shaby112 reopened this Sep 20, 2023

shaby112 requested a review from AryanSharma21 September 21, 2023 11:53

saeedashrraf changed the title ~~Added logsumexp function in paddlepaddle frontend~~ feat(frontend): Added logsumexp function in paddlepaddle frontend Oct 21, 2023

🤖 Lint code

16c812d

ivy-leaves unassigned saeedashrraf Dec 23, 2023

ivy-seed assigned Ishticode Dec 23, 2023

Merge remote-tracking branch 'upstream/main' into pr/21725

95ed153

NripeshN merged commit f655b4c into ivy-llc:main Jan 2, 2024
131 of 140 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(frontend): Added logsumexp function in paddlepaddle frontend #21725

feat(frontend): Added logsumexp function in paddlepaddle frontend #21725

shaby112 commented Aug 11, 2023 •

edited

Loading

github-actions bot commented Aug 11, 2023

ivy-leaves commented Aug 11, 2023

AryanSharma21 left a comment

shaby112 commented Aug 12, 2023

sagewhocodes Aug 14, 2023

shaby112 Aug 14, 2023

sagewhocodes commented Aug 14, 2023

shaby112 commented Aug 14, 2023

shaby112 left a comment

shaby112 Aug 14, 2023

shaby112 left a comment

shaby112 left a comment

sagewhocodes commented Aug 18, 2023

sagewhocodes Aug 18, 2023 •

edited

Loading

sagewhocodes Aug 18, 2023

shaby112 Aug 18, 2023

shaby112 Aug 18, 2023

sagewhocodes commented Aug 18, 2023

shaby112 commented Aug 18, 2023

shaby112 commented Sep 1, 2023

shaby112 commented Sep 5, 2023

shaby112 commented Sep 20, 2023

shaby112 commented Sep 20, 2023

github-actions bot commented Oct 21, 2023

NripeshN commented Jan 2, 2024



		@with_supported_dtypes(
		{"2.5.1 and below": ("float32", "float64")}, "paddle"

feat(frontend): Added logsumexp function in paddlepaddle frontend #21725

feat(frontend): Added logsumexp function in paddlepaddle frontend #21725

Conversation

shaby112 commented Aug 11, 2023 • edited Loading

github-actions bot commented Aug 11, 2023

ivy-leaves commented Aug 11, 2023

AryanSharma21 left a comment

Choose a reason for hiding this comment

shaby112 commented Aug 12, 2023

sagewhocodes Aug 14, 2023

Choose a reason for hiding this comment

shaby112 Aug 14, 2023

Choose a reason for hiding this comment

sagewhocodes commented Aug 14, 2023

shaby112 commented Aug 14, 2023

shaby112 left a comment

Choose a reason for hiding this comment

shaby112 Aug 14, 2023

Choose a reason for hiding this comment

shaby112 left a comment

Choose a reason for hiding this comment

shaby112 left a comment

Choose a reason for hiding this comment

sagewhocodes commented Aug 18, 2023

sagewhocodes Aug 18, 2023 • edited Loading

Choose a reason for hiding this comment

sagewhocodes Aug 18, 2023

Choose a reason for hiding this comment

shaby112 Aug 18, 2023

Choose a reason for hiding this comment

shaby112 Aug 18, 2023

Choose a reason for hiding this comment

sagewhocodes commented Aug 18, 2023

shaby112 commented Aug 18, 2023

shaby112 commented Sep 1, 2023

shaby112 commented Sep 5, 2023

shaby112 commented Sep 20, 2023

shaby112 commented Sep 20, 2023

github-actions bot commented Oct 21, 2023

NripeshN commented Jan 2, 2024

shaby112 commented Aug 11, 2023 •

edited

Loading

sagewhocodes Aug 18, 2023 •

edited

Loading