Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ifft2_function #21742

Closed
wants to merge 3 commits into from
Closed

ifft2_function #21742

wants to merge 3 commits into from

Conversation

teckno
Copy link
Contributor

@teckno teckno commented Aug 12, 2023 •
edited by fnhirwa
Loading

close #21741

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@teckno teckno mentioned this pull request Aug 12, 2023
Open
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 12, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

fnhirwa
fnhirwa suggested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @teckno

Check the comments below 😊
Thanks

ivy/functional/frontends/paddle/fft.py
@@ -100,3 +100,6 @@ def ifftshift(x, axes=None, name=None):
roll = ivy.roll(x, shifts, axis=axes)

return roll
@to_ivy_arrays_and_back
def ifft2(x, n=None, axis=(-2, -1), norm="backward", name=None):
return ifft2(x, n, axis, norm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no call from Ivy this seems to be a recursive call of the same function🙄 also this function isn't implemented on the Ivy API, yet you can use ifftn to implement this function

@NripeshN NripeshN closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa requested changes

Assignees

@Sarvesh-Kesharwani Sarvesh-Kesharwani

Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ifft2
5 participants
@teckno @ivy-leaves @fnhirwa @Sarvesh-Kesharwani @NripeshN