Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for array instantiation from range built-in function #21835

Closed
wants to merge 5 commits into from
Closed

added support for array instantiation from range built-in function #21835

wants to merge 5 commits into from

Conversation

illia-bab
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

Copy link
Contributor

@AryanSharma21 AryanSharma21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @illia-bab , is there any linked issue for this pull request?

@illia-bab
Copy link
Contributor Author

Hey @AryanSharma21 , there's a related trello card and a corresponding discussion in issues thread for this.

@illia-bab illia-bab requested review from fnhirwa and removed request for AryanSharma21 August 16, 2023 07:41
Copy link
Contributor

@zaeemansari70 zaeemansari70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @sherry30 and @MahmoudAshraf97 would be the best ones to review this as this is a change in asarray, given that they have worked alot in this, thanks!

@illia-bab illia-bab removed the request for review from fnhirwa August 16, 2023 18:26
@illia-bab illia-bab closed this by deleting the head repository Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants