Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ivy.dot docs and backend versions #21969

Merged
merged 4 commits into from
Aug 16, 2023
Merged

fix ivy.dot docs and backend versions #21969

merged 4 commits into from
Aug 16, 2023

Conversation

TugayGul
Copy link
Contributor

No description provided.

… does the job and changed backend implementation of tensorflow dot because it require axes parameter to work
…or does the job and changed backend function to matmul since torch.dot works only with 1D. fixed ivy.dot docs.
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Aug 15, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sondertg Your changes look good to me.
Can you do me a favor and add test_dot in test_functional...
For some reason this function does not have a test accompnaying as seen in the #21464.
I will merge this and thank you very much for you contribution : )
You are welcome to add the test for dot in a new PR (like other tests in test_functional/test_experimental/test_core) and we can ensure the function works correctly.

@Ishticode Ishticode merged commit 9bee42a into ivy-llc:main Aug 16, 2023
514 of 533 checks passed
sushmanthreddy pushed a commit to sushmanthreddy/ivy that referenced this pull request Aug 17, 2023
@TugayGul TugayGul deleted the copy2 branch August 26, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants