-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ivy.dot docs and backend versions #21969
Conversation
… does the job and changed backend implementation of tensorflow dot because it require axes parameter to work
…or does the job and changed backend function to matmul since torch.dot works only with 1D. fixed ivy.dot docs.
Thanks for contributing to Ivy! 😊👏 |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sondertg Your changes look good to me.
Can you do me a favor and add test_dot
in test_functional...
For some reason this function does not have a test accompnaying as seen in the #21464.
I will merge this and thank you very much for you contribution : )
You are welcome to add the test for dot
in a new PR (like other tests in test_functional/test_experimental/test_core) and we can ensure the function works correctly.
No description provided.