Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digamma function for Tensorflow frontend #21989

Closed
wants to merge 1 commit into from
Closed

Add digamma function for Tensorflow frontend #21989

wants to merge 1 commit into from

Conversation

jarib047
Copy link

Close #20206

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Aug 16, 2023
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Can you try to resolve the failure in the CI
AssertionError: returned dtype = float64, ground-truth returned dtype = float32

Thanks

@sherry30 sherry30 added the Stale label Aug 25, 2023
@jarib047
Copy link
Author

Hello,
This error "AssertionError: returned dtype = float64, ground-truth returned dtype = float32" seems to occur due to the digamma function returning a NaN value with a different data type.

I haven't found any way to navigate around it, could you help me with this?

Thanks.

@jarib047 jarib047 closed this Sep 17, 2023
@jarib047 jarib047 deleted the digamma branch September 17, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digamma
3 participants