Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unshuffle #22247

Closed
wants to merge 0 commits into from
Closed

add unshuffle #22247

wants to merge 0 commits into from

Conversation

AmeenUrRehman
Copy link
Contributor

@AmeenUrRehman AmeenUrRehman commented Aug 20, 2023 •
edited
Loading

Solving this issue - [ ] #22239

Hii @YushaArif99 could you review my Pull Request

Hii @YushaArif99 @AnnaTz could u review my pr

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist labels Aug 20, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@AmeenUrRehman
Copy link
Contributor Author

AmeenUrRehman commented Aug 27, 2023 •
edited
Loading

@YushaArif99 Plz review this
@YushaArif99 Plz review this 😄

@AmeenUrRehman
Copy link
Contributor Author

@AnnaTz could u plz review this 😢

YushaArif99
YushaArif99 reviewed Sep 2, 2023
View reviewed changes
...t_ivy/test_frontends/test_numpy/test_mathematical_functions/test_exponents_and_logarithms.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you kindly revert this change 🙂

YushaArif99
YushaArif99 requested changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@YushaArif99 YushaArif99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AmeenUrRehman

Apologies for the delay in the review. Was away traveling for a few weeks due to which I couldnt responsive to the PRs 😓

With regards to your PR, the implementation does look good to me. Could you kindly resolve the merge conflicts and then re-request a review? The CI tests are failing with a weird dill import error which I think should go away after the conflicts have been resolved. Thanks! 🙂

@AmeenUrRehman AmeenUrRehman reopened this Sep 2, 2023
@AmeenUrRehman
Copy link
Contributor Author

Sure, I'll try to resolve this, sorry it closed by mistake.

@AmeenUrRehman
Copy link
Contributor Author

@YushaArif99 hey could u check now.

YushaArif99
YushaArif99 requested changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@YushaArif99 YushaArif99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AmeenUrRehman, the conflicts are still showing though 😅. Could you try resolving them once again? Thanks!

@AmeenUrRehman
Copy link
Contributor Author

Sure, working on it.

@AmeenUrRehman
Copy link
Contributor Author

@YushaArif99 , I'll open another pr soon. Their is some problem in my environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YushaArif99 YushaArif99 YushaArif99 requested changes

Assignees

@YushaArif99 YushaArif99

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmeenUrRehman @ivy-leaves @YushaArif99