Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lstsq #22532

Closed
wants to merge 3 commits into from
Closed

lstsq #22532

wants to merge 3 commits into from

Conversation

TomiMalamud
Copy link

Close #22530

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 25, 2023
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
The frontend implementation should be composed of ivy functions. You can read more about it in our docs.
You will also have to implement a test function for this frontend function and get it to pass.

All of these things are well documented in the docs so make sure to go through those first and then feel free to ask any questions.

Thanks

@TomiMalamud TomiMalamud reopened this Aug 29, 2023
Copy link
Author

@TomiMalamud TomiMalamud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new tests

@TomiMalamud
Copy link
Author

Close #22532

@sherry30
Copy link
Contributor

Hey,

I just noticed that someone has already opened PR for this function before you, they commented it first here.
So I would suggest that you pick a different function, a one which is not already picked and no one has commented.

Sorry for realizing a lot later. 😅

Thanks

@sherry30 sherry30 closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lstsq
3 participants