Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unpackbits to jax frontend #22629

Merged
merged 12 commits into from
Jul 10, 2024
Merged

Conversation

SiLyGoose
Copy link
Contributor

@SiLyGoose SiLyGoose commented Aug 26, 2023

Close #22630

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Aug 26, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

x = ivy.swapaxes(x, axis, -1)

unpacked = (
(x[..., None] & ivy.expand_dims(bits, axis=tuple(range(x.rdim)))) > 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that x.rdim is causing all the test failures so far. Could you please fix it?

@SiLyGoose SiLyGoose reopened this Sep 6, 2023
@SiLyGoose SiLyGoose closed this Sep 6, 2023
@SiLyGoose SiLyGoose reopened this Sep 6, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed added the Stale label Dec 31, 2023
@joaozenobio
Copy link
Contributor

Hi @SiLyGoose ! Thanks for the PR. If you need any assistance please pin me 😄

@joaozenobio joaozenobio changed the title unpackbits to jax frontend Feat: add unpackbits to jax frontend Feb 1, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

@joaozenobio joaozenobio changed the title Feat: add unpackbits to jax frontend feat: add unpackbits to jax frontend Feb 1, 2024
@joaozenobio joaozenobio removed their assignment Feb 24, 2024
@Sam-Armstrong Sam-Armstrong removed the request for review from zhumakhan July 10, 2024 12:19
@Sam-Armstrong Sam-Armstrong merged commit a373675 into ivy-llc:main Jul 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unpackbits
7 participants